Make PNaCl component downloadable for chromeos-chrome built for Linux

Make PNaCl component downloadable for chromeos-chrome built for Linux

Chrome4ChromeOS for Linux packages needs pNaCl but it is not part of package
so make it downloadable when running on Linux. In Chrome OS PNaCl is part of
rootfs.

BUG=422121
TEST=manual

Committed: https://crrev.com/c2ff5667ca19b3d7dbca7cf8985e27a9d4d0a876
Cr-Commit-Position: refs/heads/master@{#300236}

[Dmitry Polukhin, 2014-10-17 15:05:38]

dpolukhin@chromium.org changed reviewers:
+ jvoung@chromium.org, thestig@chromium.org

[Dmitry Polukhin, 2014-10-17 15:05:38]

PTAL

[jvoung (off chromium), 2014-10-17 16:55:47]

LGTM (but I'm not an owner of browser_main)

https://codereview.chromium.org/662713006/diff/1/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/662713006/diff/1/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main.cc:147: #include "base/sys_info.h"
I think sys_info is already included above, so this may not be needed.

https://codereview.chromium.org/662713006/diff/1/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main.cc:410: if
(!base::SysInfo::IsRunningOnChromeOS())
Maybe leave a comment that on ChromeOS it's part of the rootfs, but not for
Chrome4ChromeOS on Linux?

... tradeoff between comments going stale and figuring out why it is these
conditions. Up to you or Lei.

[Lei Zhang, 2014-10-17 21:59:55]

lgtm

https://codereview.chromium.org/662713006/diff/1/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/662713006/diff/1/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main.cc:410: if
(!base::SysInfo::IsRunningOnChromeOS())
On 2014/10/17 16:55:47, jvoung wrote:
> Maybe leave a comment that on ChromeOS it's part of the rootfs, but not for
> Chrome4ChromeOS on Linux?
> 
> ... tradeoff between comments going stale and figuring out why it is these
> conditions. Up to you or Lei.

A comment would be good. Otherwise it's not obvious at all why we need this.

[Dmitry Polukhin, 2014-10-20 07:14:23]

Thank you for the review!

https://codereview.chromium.org/662713006/diff/1/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/662713006/diff/1/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main.cc:147: #include "base/sys_info.h"
On 2014/10/17 16:55:47, jvoung wrote:
> I think sys_info is already included above, so this may not be needed.

Good catch, thank you!

https://codereview.chromium.org/662713006/diff/1/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main.cc:410: if
(!base::SysInfo::IsRunningOnChromeOS())
On 2014/10/17 21:59:55, Lei Zhang wrote:
> On 2014/10/17 16:55:47, jvoung wrote:
> > Maybe leave a comment that on ChromeOS it's part of the rootfs, but not for
> > Chrome4ChromeOS on Linux?
> > 
> > ... tradeoff between comments going stale and figuring out why it is these
> > conditions. Up to you or Lei.
> 
> A comment would be good. Otherwise it's not obvious at all why we need this.

Done.

[Dmitry Polukhin, 2014-10-20 07:14:33]

The CQ bit was checked by dpolukhin@chromium.org

[commit-bot: I haz the power, 2014-10-20 07:16:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/662713006/20001

[commit-bot: I haz the power, 2014-10-20 09:34:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-20 09:35:54]

Patchset 2 (id:??) landed as
https://crrev.com/c2ff5667ca19b3d7dbca7cf8985e27a9d4d0a876
Cr-Commit-Position: refs/heads/master@{#300236}