chrome/common/render_messages_internal.h - Issue 6627063: Ignore JavaScript messages (alert/confirm/prompt) during unload handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/render_messages_internal.h

Issue 6627063: Ignore JavaScript messages (alert/confirm/prompt) during unload handlers. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Added a browsertest Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/render_messages_internal.h

diff --git a/chrome/common/render_messages_internal.h b/chrome/common/render_messages_internal.h

index f3dfdc8d3430d858800d0957357f3654baad2e11..6ed558f85a04bb1cbac6b23582efda95525d24d8 100644

--- a/chrome/common/render_messages_internal.h

+++ b/chrome/common/render_messages_internal.h

@@ -1323,11 +1323,12 @@ IPC_MESSAGE_ROUTED2(ViewHostMsg_DownloadUrl,

IPC_MESSAGE_ROUTED1(ViewHostMsg_GoToEntryAtOffset,

int /* offset (from current) of history item to get */)

-IPC_SYNC_MESSAGE_ROUTED4_2(ViewHostMsg_RunJavaScriptMessage,

+IPC_SYNC_MESSAGE_ROUTED5_2(ViewHostMsg_RunJavaScriptMessage,

std::wstring /* in - alert message */,

std::wstring /* in - default prompt */,

GURL /* in - originating page URL */,

int /* in - dialog flags */,

+ bool /* in - unload handler being run? */,

bool /* out - success */,

std::wstring /* out - prompt field */)

« no previous file with comments | « chrome/browser/tab_contents/web_contents_unittest.cc ('k') | chrome/renderer/render_view.h » ('j') | no next file with comments »