chrome/browser/tab_contents/background_contents.cc - Issue 6627063: Ignore JavaScript messages (alert/confirm/prompt) during unload handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/background_contents.cc

Issue 6627063: Ignore JavaScript messages (alert/confirm/prompt) during unload handlers. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Added a browsertest Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/tab_contents/background_contents.cc

diff --git a/chrome/browser/tab_contents/background_contents.cc b/chrome/browser/tab_contents/background_contents.cc

index e9ea273c2d9758a6e2a8d620cef1905c4198ff43..d030211ffeaf9a58a0a3121f0ccc4ae4470b08f7 100644

--- a/chrome/browser/tab_contents/background_contents.cc

+++ b/chrome/browser/tab_contents/background_contents.cc

@@ -109,6 +109,7 @@ void BackgroundContents::RunJavaScriptMessage(

const std::wstring& default_prompt,

const GURL& frame_url,

const int flags,

+ const bool unload_handler_being_run,

IPC::Message* reply_msg,

bool* did_suppress_message) {

// TODO(rafaelw): Implement, The JavaScriptModalDialog needs to learn about

« no previous file with comments | « chrome/browser/tab_contents/background_contents.h ('k') | chrome/browser/tab_contents/web_contents_unittest.cc » ('j') | no next file with comments »