Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: content/browser/renderer_host/render_view_host.h

Issue 6627063: Ignore JavaScript messages (alert/confirm/prompt) during unload handlers. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Added a browsertest Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | content/browser/renderer_host/render_view_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 579 matching lines...) Expand 10 before | Expand all | Expand 10 after
590 const std::string& origin, 590 const std::string& origin,
591 const std::string& target); 591 const std::string& target);
592 void OnMsgSetTooltipText(const std::wstring& tooltip_text, 592 void OnMsgSetTooltipText(const std::wstring& tooltip_text,
593 WebKit::WebTextDirection text_direction_hint); 593 WebKit::WebTextDirection text_direction_hint);
594 void OnMsgSelectionChanged(const std::string& text); 594 void OnMsgSelectionChanged(const std::string& text);
595 void OnMsgPasteFromSelectionClipboard(); 595 void OnMsgPasteFromSelectionClipboard();
596 void OnMsgRunJavaScriptMessage(const std::wstring& message, 596 void OnMsgRunJavaScriptMessage(const std::wstring& message,
597 const std::wstring& default_prompt, 597 const std::wstring& default_prompt,
598 const GURL& frame_url, 598 const GURL& frame_url,
599 const int flags, 599 const int flags,
600 const bool unload_handler_being_run,
600 IPC::Message* reply_msg); 601 IPC::Message* reply_msg);
601 void OnMsgRunBeforeUnloadConfirm(const GURL& frame_url, 602 void OnMsgRunBeforeUnloadConfirm(const GURL& frame_url,
602 const std::wstring& message, 603 const std::wstring& message,
603 IPC::Message* reply_msg); 604 IPC::Message* reply_msg);
604 void OnMsgStartDragging(const WebDropData& drop_data, 605 void OnMsgStartDragging(const WebDropData& drop_data,
605 WebKit::WebDragOperationsMask operations_allowed, 606 WebKit::WebDragOperationsMask operations_allowed,
606 const SkBitmap& image, 607 const SkBitmap& image,
607 const gfx::Point& image_offset); 608 const gfx::Point& image_offset);
608 void OnUpdateDragCursor(WebKit::WebDragOperation drag_operation); 609 void OnUpdateDragCursor(WebKit::WebDragOperation drag_operation);
609 void OnTakeFocus(bool reverse); 610 void OnTakeFocus(bool reverse);
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
727 // The termination status of the last render view that terminated. 728 // The termination status of the last render view that terminated.
728 base::TerminationStatus render_view_termination_status_; 729 base::TerminationStatus render_view_termination_status_;
729 730
730 // The enabled/disabled states of various commands. 731 // The enabled/disabled states of various commands.
731 std::map<RenderViewCommand, CommandState> command_states_; 732 std::map<RenderViewCommand, CommandState> command_states_;
732 733
733 DISALLOW_COPY_AND_ASSIGN(RenderViewHost); 734 DISALLOW_COPY_AND_ASSIGN(RenderViewHost);
734 }; 735 };
735 736
736 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_ 737 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_H_
OLDNEW
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | content/browser/renderer_host/render_view_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698