Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: chrome/renderer/render_view.h

Issue 6627063: Ignore JavaScript messages (alert/confirm/prompt) during unload handlers. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Added a browsertest Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/common/render_messages_internal.h ('k') | chrome/renderer/render_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_RENDER_VIEW_H_ 5 #ifndef CHROME_RENDERER_RENDER_VIEW_H_
6 #define CHROME_RENDERER_RENDER_VIEW_H_ 6 #define CHROME_RENDERER_RENDER_VIEW_H_
7 #pragma once 7 #pragma once
8 8
9 #include <deque> 9 #include <deque>
10 #include <map> 10 #include <map>
(...skipping 749 matching lines...) Expand 10 before | Expand all | Expand 10 after
760 ThumbnailScore* score); 760 ThumbnailScore* score);
761 761
762 // Capture a snapshot of a view. This is used to allow an extension 762 // Capture a snapshot of a view. This is used to allow an extension
763 // to get a snapshot of a tab using chrome.tabs.captureVisibleTab(). 763 // to get a snapshot of a tab using chrome.tabs.captureVisibleTab().
764 bool CaptureSnapshot(WebKit::WebView* view, SkBitmap* snapshot); 764 bool CaptureSnapshot(WebKit::WebView* view, SkBitmap* snapshot);
765 765
766 bool RunJavaScriptMessage(int type, 766 bool RunJavaScriptMessage(int type,
767 const std::wstring& message, 767 const std::wstring& message,
768 const std::wstring& default_value, 768 const std::wstring& default_value,
769 const GURL& frame_url, 769 const GURL& frame_url,
770 bool unload_handler_being_run,
770 std::wstring* result); 771 std::wstring* result);
771 772
772 // Sends a message and runs a nested message loop. 773 // Sends a message and runs a nested message loop.
773 bool SendAndRunNestedMessageLoop(IPC::SyncMessage* message); 774 bool SendAndRunNestedMessageLoop(IPC::SyncMessage* message);
774 775
775 // Adds search provider from the given OpenSearch description URL as a 776 // Adds search provider from the given OpenSearch description URL as a
776 // keyword search. 777 // keyword search.
777 void AddGURLSearchProvider(const GURL& osd_url, 778 void AddGURLSearchProvider(const GURL& osd_url,
778 const ViewHostMsg_PageHasOSDD_Type& provider_type); 779 const ViewHostMsg_PageHasOSDD_Type& provider_type);
779 780
(...skipping 655 matching lines...) Expand 10 before | Expand all | Expand 10 after
1435 // bunch of stuff, you should probably create a helper class and put your 1436 // bunch of stuff, you should probably create a helper class and put your
1436 // data and methods on that to avoid bloating RenderView more. You can use 1437 // data and methods on that to avoid bloating RenderView more. You can use
1437 // the Observer interface to filter IPC messages and receive frame change 1438 // the Observer interface to filter IPC messages and receive frame change
1438 // notifications. 1439 // notifications.
1439 // --------------------------------------------------------------------------- 1440 // ---------------------------------------------------------------------------
1440 1441
1441 DISALLOW_COPY_AND_ASSIGN(RenderView); 1442 DISALLOW_COPY_AND_ASSIGN(RenderView);
1442 }; 1443 };
1443 1444
1444 #endif // CHROME_RENDERER_RENDER_VIEW_H_ 1445 #endif // CHROME_RENDERER_RENDER_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/common/render_messages_internal.h ('k') | chrome/renderer/render_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698