Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Side by Side Diff: chrome/browser/extensions/extension_host.h

Issue 6627063: Ignore JavaScript messages (alert/confirm/prompt) during unload handlers. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Added a browsertest Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/browser_browsertest.cc ('k') | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 int32 page_id); 127 int32 page_id);
128 128
129 // RenderViewHostDelegate implementation. 129 // RenderViewHostDelegate implementation.
130 virtual RenderViewHostDelegate::View* GetViewDelegate(); 130 virtual RenderViewHostDelegate::View* GetViewDelegate();
131 virtual WebPreferences GetWebkitPrefs(); 131 virtual WebPreferences GetWebkitPrefs();
132 virtual void ProcessWebUIMessage(const ViewHostMsg_DomMessage_Params& params); 132 virtual void ProcessWebUIMessage(const ViewHostMsg_DomMessage_Params& params);
133 virtual void RunJavaScriptMessage(const std::wstring& message, 133 virtual void RunJavaScriptMessage(const std::wstring& message,
134 const std::wstring& default_prompt, 134 const std::wstring& default_prompt,
135 const GURL& frame_url, 135 const GURL& frame_url,
136 const int flags, 136 const int flags,
137 const bool unload_handler_being_run,
137 IPC::Message* reply_msg, 138 IPC::Message* reply_msg,
138 bool* did_suppress_message); 139 bool* did_suppress_message);
139 virtual void Close(RenderViewHost* render_view_host); 140 virtual void Close(RenderViewHost* render_view_host);
140 virtual RendererPreferences GetRendererPrefs(Profile* profile) const; 141 virtual RendererPreferences GetRendererPrefs(Profile* profile) const;
141 142
142 // RenderViewHostDelegate::View 143 // RenderViewHostDelegate::View
143 virtual void CreateNewWindow( 144 virtual void CreateNewWindow(
144 int route_id, 145 int route_id,
145 const ViewHostMsg_CreateWindow_Params& params); 146 const ViewHostMsg_CreateWindow_Params& params);
146 virtual void CreateNewWidget(int route_id, WebKit::WebPopupType popup_type); 147 virtual void CreateNewWidget(int route_id, WebKit::WebPopupType popup_type);
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
293 // The time that the last javascript message was dismissed. 294 // The time that the last javascript message was dismissed.
294 base::TimeTicks last_javascript_message_dismissal_; 295 base::TimeTicks last_javascript_message_dismissal_;
295 296
296 // Whether to suppress all javascript messages. 297 // Whether to suppress all javascript messages.
297 bool suppress_javascript_messages_; 298 bool suppress_javascript_messages_;
298 299
299 DISALLOW_COPY_AND_ASSIGN(ExtensionHost); 300 DISALLOW_COPY_AND_ASSIGN(ExtensionHost);
300 }; 301 };
301 302
302 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_ 303 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_H_
OLDNEW
« no previous file with comments | « chrome/browser/browser_browsertest.cc ('k') | chrome/browser/extensions/extension_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698