Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/browser/extensions/extension_menu_manager_unittest.cc

Issue 6627060: ImportantFileWriter: check return value of PostTask... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_commands_unittest.cc ('k') | chrome/browser/extensions/extension_prefs_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_menu_manager_unittest.cc
===================================================================
--- chrome/browser/extensions/extension_menu_manager_unittest.cc (revision 77440)
+++ chrome/browser/extensions/extension_menu_manager_unittest.cc (working copy)
@@ -31,8 +31,11 @@
// Base class for tests.
class ExtensionMenuManagerTest : public testing::Test {
public:
- ExtensionMenuManagerTest() : next_id_(1) {}
- ~ExtensionMenuManagerTest() {}
+ ExtensionMenuManagerTest()
+ : ui_thread_(BrowserThread::UI, &message_loop_),
+ file_thread_(BrowserThread::FILE, &message_loop_),
+ next_id_(1) {
+ }
// Returns a test item.
ExtensionMenuItem* CreateTestItem(Extension* extension) {
@@ -51,6 +54,10 @@
}
protected:
+ MessageLoopForUI message_loop_;
+ BrowserThread ui_thread_;
+ BrowserThread file_thread_;
+
ExtensionMenuManager manager_;
ExtensionList extensions_;
TestExtensionPrefs prefs_;
@@ -409,9 +416,6 @@
}
TEST_F(ExtensionMenuManagerTest, ExecuteCommand) {
- MessageLoopForUI message_loop;
- BrowserThread ui_thread(BrowserThread::UI, &message_loop);
-
MockTestingProfile profile;
scoped_ptr<MockExtensionEventRouter> mock_event_router(
« no previous file with comments | « chrome/browser/browser_commands_unittest.cc ('k') | chrome/browser/extensions/extension_prefs_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698