Issue 6627037: Suppress many Valgrind reports on the memory waterfall...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6627037: Suppress many Valgrind reports on the memory waterfall... (Closed)

Created:
9 years, 9 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Suppress many Valgrind reports on the memory waterfall TBR=glider BUG=75019, 75020, 75021, 75023 TEST=Memory waterfall goes green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77040

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -2 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		3 chunks	+77 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

9 years, 9 months ago (2011-03-05 12:17:24 UTC) #2

LGTM

http://codereview.chromium.org/6627037/diff/1/tools/valgrind/memcheck/suppres...
File tools/valgrind/memcheck/suppressions.txt (right):

http://codereview.chromium.org/6627037/diff/1/tools/valgrind/memcheck/suppres...
tools/valgrind/memcheck/suppressions.txt:825:
fun:_ZN1}RenderViewHost16CreateRenderViewERKSbItN4base20string16_char_traitsESaItEE
s/}/4
Please fix.

Expand Messages | Collapse Messages