Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 662703003: Excluded ipc/ipc_logging.cc to check for spam logging (Closed)

Created:
6 years, 1 month ago by prashant.n
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Excluded ipc/ipc_logging.cc to check for spam logging Added ipc/ipc_logging.cc to exclude for spam logging in presubmit check as it needs to output log to stderr. Committed: https://crrev.com/b0252f62bfc135bf2145f5106b86b86590ac1a1b Cr-Commit-Position: refs/heads/master@{#303376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
prashant.n
PTAL.
6 years, 1 month ago (2014-10-25 17:48:46 UTC) #1
prashant.n
6 years, 1 month ago (2014-10-25 18:09:17 UTC) #2
prashant.n
PTAL
6 years, 1 month ago (2014-10-25 18:10:13 UTC) #4
M-A Ruel
Can you point to a CL which requires this?
6 years, 1 month ago (2014-10-28 21:11:33 UTC) #5
prashant.n
On 2014/10/28 21:11:33, M-A Ruel wrote: > Can you point to a CL which requires ...
6 years, 1 month ago (2014-10-29 18:12:39 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 1 month ago (2014-11-07 17:59:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662703003/1
6 years, 1 month ago (2014-11-08 04:18:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-08 05:02:17 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 05:03:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0252f62bfc135bf2145f5106b86b86590ac1a1b
Cr-Commit-Position: refs/heads/master@{#303376}

Powered by Google App Engine
This is Rietveld 408576698