[android] Use correct view type for dropdown.

[android] Use correct view type for dropdown.

This patch changes DropdownPopupWindow to check the type of the view in
each element of the popup list when measuring the width of its contents.
This ensures that popup list adapters that use multiple view types do
not have to check the type of the view in getView() method. One example
of adapter that uses multiple types of views is
PasswordGenerationAdapter.

BUG=412150
Committed: https://crrev.com/4f2e5f49c05805761065b3ce7f97e9258ffbd4c9
Cr-Commit-Position: refs/heads/master@{#301298}

[please use gerrit instead, 2014-10-23 18:18:21]

rouslan@chromium.org changed reviewers:
+ aurimas@chromium.org

[please use gerrit instead, 2014-10-23 18:18:22]

Aurimas: PTAL Patch Set 2.

I've split this off from https://codereview.chromium.org/606153002/.

To answer your question from https://codereview.chromium.org/606153002/,
mAdapter can be null if someone invokes setAnchorRect() without calling
setAdapter() first. There's no place in code that does this at the moment,
though.

[aurimas (slooooooooow), 2014-10-24 20:25:10]

lgtm

https://codereview.chromium.org/662683005/diff/20001/ui/android/java/src/org/...
File ui/android/java/src/org/chromium/ui/DropdownPopupWindow.java (right):

https://codereview.chromium.org/662683005/diff/20001/ui/android/java/src/org/...
ui/android/java/src/org/chromium/ui/DropdownPopupWindow.java:162: if (mAdapter
== null) return 0;
Should this we an assert instead?

[please use gerrit instead, 2014-10-24 21:07:07]

https://codereview.chromium.org/662683005/diff/20001/ui/android/java/src/org/...
File ui/android/java/src/org/chromium/ui/DropdownPopupWindow.java (right):

https://codereview.chromium.org/662683005/diff/20001/ui/android/java/src/org/...
ui/android/java/src/org/chromium/ui/DropdownPopupWindow.java:162: if (mAdapter
== null) return 0;
On 2014/10/24 20:25:09, aurimas wrote:
> Should this we an assert instead?

Sounds good. Done.

[please use gerrit instead, 2014-10-24 21:08:48]

rouslan@chromium.org changed reviewers:
+ newt@chromium.org

[please use gerrit instead, 2014-10-24 21:08:49]

rouslan@chromium.org changed required reviewers:
+ newt@chromium.org

[please use gerrit instead, 2014-10-24 21:08:49]

Newton: OWNERS PTAL Patch Set 3.

[newt (away), 2014-10-24 21:12:38]

On 2014/10/24 21:08:49, Rouslan Solomakhin wrote:
> Newton: OWNERS PTAL Patch Set 3.

lgtm

[please use gerrit instead, 2014-10-24 21:23:49]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2014-10-24 21:24:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/662683005/40001

[please use gerrit instead, 2014-10-24 23:06:02]

The CQ bit was unchecked by rouslan@chromium.org

[please use gerrit instead, 2014-10-25 00:08:36]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2014-10-25 00:10:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/662683005/60001

[commit-bot: I haz the power, 2014-10-25 06:11:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-25 06:11:43]

Exceeded time limit waiting for builds to trigger.

[please use gerrit instead, 2014-10-25 21:56:10]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2014-10-25 21:56:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/662683005/60001

[commit-bot: I haz the power, 2014-10-25 23:29:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-25 23:30:24]

Patchset 4 (id:??) landed as
https://crrev.com/4f2e5f49c05805761065b3ce7f97e9258ffbd4c9
Cr-Commit-Position: refs/heads/master@{#301298}