Issue 662683003: [NaCl SDK] Run PNaCl translate tests in sel_ldr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 662683003: [NaCl SDK] Run PNaCl translate tests in sel_ldr. (Closed)

Created:
6 years, 2 months ago by binji

Modified:
6 years, 2 months ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

[NaCl SDK] Run PNaCl translate tests in sel_ldr. The offline pnacl translator was not being tested anywhere after we switched to using pnacl debug info. BUG=none R=sbc@chromium.org Committed: https://crrev.com/9c5e249179d2c52754bf61bf74af62ebe6ac7a3d Cr-Commit-Position: refs/heads/master@{#300119}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -3 lines)			Patch
M	native_client_sdk/src/build_tools/test_sdk.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	native_client_sdk/src/resources/Makefile.example.template	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	native_client_sdk/src/resources/Makefile.library.template	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	native_client_sdk/src/tools/nacl_llvm.mk	View	4 chunks	+34 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662683003/1

6 years, 2 months ago (2014-10-17 16:46:57 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 16:52:08 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9c5e249179d2c52754bf61bf74af62ebe6ac7a3d
Cr-Commit-Position: refs/heads/master@{#300119}