Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 662673002: Add rendering fast path for when playing a display list canvas at 1:1 scale (Closed)

Created:
6 years, 2 months ago by Justin Novosad
Modified:
6 years, 2 months ago
Reviewers:
Stephen White
CC:
blink-reviews, krit, Rik, jbroman, mkwst+moarreviews_chromium.org, danakj, pdr+graphicswatchlist_chromium.org, Stephen Chennney, rwlbuis
Project:
blink
Visibility:
Public.

Description

Add rendering fast path for when playing a display list canvas at 1:1 scale This patch modifies GraphicsContext::drawPicture to make it avoid the use of image filters for presenting canvas contents, and just use a plain save layer when drawing contents at 1:1 pixel scale. BUG=386601 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183836

Patch Set 1 #

Total comments: 2

Patch Set 2 : epsilon constant #

Total comments: 1

Patch Set 3 : skia-ism removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -13 lines) Patch
M Source/platform/graphics/GraphicsContext.cpp View 1 2 3 chunks +41 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Justin Novosad
PTAL
6 years, 2 months ago (2014-10-16 15:30:36 UTC) #2
Stephen White
https://codereview.chromium.org/662673002/diff/1/Source/platform/graphics/GraphicsContext.cpp File Source/platform/graphics/GraphicsContext.cpp (right): https://codereview.chromium.org/662673002/diff/1/Source/platform/graphics/GraphicsContext.cpp#newcode1134 Source/platform/graphics/GraphicsContext.cpp:1134: return x > 0.999999 && x < 1.000001; Could ...
6 years, 2 months ago (2014-10-16 17:38:00 UTC) #3
Justin Novosad
new patch
6 years, 2 months ago (2014-10-16 18:01:11 UTC) #4
Stephen White
https://codereview.chromium.org/662673002/diff/20001/Source/platform/graphics/GraphicsContext.cpp File Source/platform/graphics/GraphicsContext.cpp (right): https://codereview.chromium.org/662673002/diff/20001/Source/platform/graphics/GraphicsContext.cpp#newcode68 Source/platform/graphics/GraphicsContext.cpp:68: const float kPictureScaleEpsilon = 0.000001; Looks like I just ...
6 years, 2 months ago (2014-10-16 18:49:39 UTC) #5
Justin Novosad
new patch
6 years, 2 months ago (2014-10-16 18:50:49 UTC) #6
Stephen White
LGTM
6 years, 2 months ago (2014-10-16 18:56:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662673002/40001
6 years, 2 months ago (2014-10-16 18:59:26 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 21:01:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 183836

Powered by Google App Engine
This is Rietveld 408576698