Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 66263003: Renderer-compositor bindings for mix-blend-mode (Closed)

Created:
7 years, 1 month ago by rosca
Modified:
7 years ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Renderer-compositor bindings for mix-blend-mode This patch will link the blink implementation for mix-blend-mode with the compositor implementation. Blink: https://codereview.chromium.org/23511004/ Cc: https://codereview.chromium.org/23455060/ BUG=243223 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238498 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240284

Patch Set 1 #

Patch Set 2 : extra checks for skia-blink blendMode conversions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -0 lines) Patch
A webkit/renderer/compositor_bindings/web_blend_mode.h View 1 1 chunk +106 lines, -0 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_compositing_reasons.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_layer_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_layer_impl.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rosca
These are files I removed from https://codereview.chromium.org/23455060/ and I will land them after both blink ...
7 years, 1 month ago (2013-11-11 17:59:34 UTC) #1
enne (OOO)
lgtm
7 years, 1 month ago (2013-11-11 21:01:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rosca@adobe.com/66263003/40001
7 years ago (2013-12-03 18:01:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rosca@adobe.com/66263003/40001
7 years ago (2013-12-03 19:10:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rosca@adobe.com/66263003/40001
7 years ago (2013-12-03 23:35:19 UTC) #5
commit-bot: I haz the power
Change committed as 238498
7 years ago (2013-12-04 00:44:41 UTC) #6
tonyg
A revert of this CL has been created in https://codereview.chromium.org/105333002/ by tonyg@chromium.org. The reason for ...
7 years ago (2013-12-04 19:12:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rosca@adobe.com/66263003/40001
7 years ago (2013-12-11 18:06:00 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-12 12:36:52 UTC) #9
Message was sent while issue was closed. 
Change committed as 240284

Powered by Google App Engine
This is Rietveld 408576698