Stop using AutoScratchTexture.

Stop using AutoScratchTexture.

BUG=skia:2889
Committed: https://crrev.com/0ed1df255da6f2cc29ecb8e2df8adbb615127471
Cr-Commit-Position: refs/heads/master@{#299936}

[bsalomon, 2014-10-16 15:30:46]

bsalomon@google.com changed reviewers:
+ danakj@chromium.org, senorblanco@chromium.org

[bsalomon, 2014-10-16 15:30:46]

Also addresses post-commit comments from:
https://codereview.chromium.org/520793002/

[danakj, 2014-10-16 15:34:01]

https://codereview.chromium.org/662623003/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/662623003/diff/1/cc/output/gl_renderer.cc#new...
cc/output/gl_renderer.cc:677: SkCanvas* canvas = surface->getCanvas();
can you leave this as it was? using SharePtr makes it explicit that we did the
research and aren't leaking a SkRefCnt object here. we use a "no raw SkRefCnt
pointers" to avoid leaks/UAFs

https://codereview.chromium.org/662623003/diff/1/cc/output/gl_renderer.cc#new...
cc/output/gl_renderer.cc:841: SkCanvas* canvas = surface->getCanvas();
ditto

[Stephen White, 2014-10-16 15:37:38]

LGTM

[bsalomon, 2014-10-16 16:38:57]

https://codereview.chromium.org/662623003/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/662623003/diff/1/cc/output/gl_renderer.cc#new...
cc/output/gl_renderer.cc:677: SkCanvas* canvas = surface->getCanvas();
On 2014/10/16 15:34:01, danakj wrote:
> can you leave this as it was? using SharePtr makes it explicit that we did the
> research and aren't leaking a SkRefCnt object here. we use a "no raw SkRefCnt
> pointers" to avoid leaks/UAFs

Done.

https://codereview.chromium.org/662623003/diff/1/cc/output/gl_renderer.cc#new...
cc/output/gl_renderer.cc:841: SkCanvas* canvas = surface->getCanvas();
On 2014/10/16 15:34:01, danakj wrote:
> ditto

Done.

[danakj, 2014-10-16 16:44:57]

Thanks, LGTM

[bsalomon, 2014-10-16 16:53:30]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-10-16 16:54:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/662623003/20001

[commit-bot: I haz the power, 2014-10-16 18:29:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-16 18:30:45]

Patchset 2 (id:??) landed as
https://crrev.com/0ed1df255da6f2cc29ecb8e2df8adbb615127471
Cr-Commit-Position: refs/heads/master@{#299936}

[Sungmann Cho, 2014-10-18 15:10:17]

sungmann.cho@navercorp.com changed reviewers:
+ sungmann.cho@navercorp.com

[Sungmann Cho, 2014-10-18 15:10:18]

This CL breaks current ToT.

../../cc/output/gl_renderer.cc:665:49: error: no member named
'refScratchTexture' in 'GrContext'
      skia::AdoptRef(use_gr_context->context()->refScratchTexture(
                     ~~~~~~~~~~~~~~~~~~~~~~~~~  ^
../../cc/output/gl_renderer.cc:826:49: error: no member named
'refScratchTexture' in 'GrContext'
      skia::AdoptRef(use_gr_context->context()->refScratchTexture(
                     ~~~~~~~~~~~~~~~~~~~~~~~~~  ^

[danakj, 2014-10-18 17:55:12]

On 2014/10/18 15:10:18, Sungmann Cho wrote:
> This CL breaks current ToT.
> 
> ../../cc/output/gl_renderer.cc:665:49: error: no member named
> 'refScratchTexture' in 'GrContext'
>       skia::AdoptRef(use_gr_context->context()->refScratchTexture(
>                      ~~~~~~~~~~~~~~~~~~~~~~~~~  ^
> ../../cc/output/gl_renderer.cc:826:49: error: no member named
> 'refScratchTexture' in 'GrContext'
>       skia::AdoptRef(use_gr_context->context()->refScratchTexture(
>                      ~~~~~~~~~~~~~~~~~~~~~~~~~  ^

Hm, it passed the bots.. you sure you don't need to gclient sync a skia roll?

[Sungmann Cho, 2014-10-20 00:14:53]

On 2014/10/18 17:55:12, danakj wrote:
> On 2014/10/18 15:10:18, Sungmann Cho wrote:
> > This CL breaks current ToT.
> > 
> > ../../cc/output/gl_renderer.cc:665:49: error: no member named
> > 'refScratchTexture' in 'GrContext'
> >       skia::AdoptRef(use_gr_context->context()->refScratchTexture(
> >                      ~~~~~~~~~~~~~~~~~~~~~~~~~  ^
> > ../../cc/output/gl_renderer.cc:826:49: error: no member named
> > 'refScratchTexture' in 'GrContext'
> >       skia::AdoptRef(use_gr_context->context()->refScratchTexture(
> >                      ~~~~~~~~~~~~~~~~~~~~~~~~~  ^
> 
> Hm, it passed the bots.. you sure you don't need to gclient sync a skia roll?

Oops. I missed gclient sync. Sorry about that! :(