Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 662603004: Fix Java indentation issues. (Closed)

Created:
6 years, 2 months ago by aurimas (slooooooooow)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, vsevik, zea+watch_chromium.org, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Java indentation issues. Fix indentation issues to allow enabling Checkstyle indentation rule. BUG=318404 Committed: https://crrev.com/cd44405f000d57d6481eaf33e3980747db7f771a Cr-Commit-Position: refs/heads/master@{#300162}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java View 1 chunk +8 lines, -8 lines 2 comments Download
M components/cronet/android/test/src/org/chromium/cronet_test_apk/CronetTestActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/SessionControlMessages.java View 3 chunks +7 lines, -6 lines 0 comments Download
M components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/DataChannelMock.java View 2 chunks +2 lines, -2 lines 0 comments Download
M components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/LocalTunnelBridge.java View 1 chunk +1 line, -1 line 0 comments Download
M components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/TestUtils.java View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/android/java/src/org/chromium/components/dom_distiller/core/DomDistillerService.java View 1 chunk +2 lines, -2 lines 0 comments Download
M components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMListener.java View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GoogleCloudMessagingV2.java View 3 chunks +3 lines, -5 lines 0 comments Download
M components/invalidation/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java View 1 chunk +1 line, -1 line 0 comments Download
M components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
aurimas (slooooooooow)
tedchoc@chromium.org: Please review changes in web_contents_delegate_android/ fgorski@chromium.org: Please review changes in gcm_driver/ mnaganov@chromium.org: Please review ...
6 years, 2 months ago (2014-10-16 19:14:53 UTC) #2
fgorski
lgtm
6 years, 2 months ago (2014-10-16 19:18:20 UTC) #3
mef
lgtm, with questions. :) Does it make sense to limit line length to 80 to ...
6 years, 2 months ago (2014-10-16 19:34:39 UTC) #4
Ted C
lgtm
6 years, 2 months ago (2014-10-16 19:49:05 UTC) #5
aurimas (slooooooooow)
Java style sets line limit to 100. You can adjust retvield: https://screenshot.googleplex.com/gUu51Zrvs5 https://chromiumcodereview.appspot.com/662603004/diff/1/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java File components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java ...
6 years, 2 months ago (2014-10-16 20:28:21 UTC) #6
aurimas (slooooooooow)
Java style sets line limit to 100. You can adjust retvield: https://screenshot.googleplex.com/gUu51Zrvs5 https://chromiumcodereview.appspot.com/662603004/diff/1/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java File components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java ...
6 years, 2 months ago (2014-10-16 20:28:22 UTC) #7
mnaganov (inactive)
devtools_bridge/ changes LGTM Thanks for fixing!
6 years, 2 months ago (2014-10-17 07:40:21 UTC) #8
aurimas (slooooooooow)
Nyquist: ping?
6 years, 2 months ago (2014-10-17 15:01:07 UTC) #9
nyquist
dom_distiller/ and invalidation/ lgtm
6 years, 2 months ago (2014-10-17 20:38:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662603004/1
6 years, 2 months ago (2014-10-17 20:39:49 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 21:12:41 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 21:15:42 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd44405f000d57d6481eaf33e3980747db7f771a
Cr-Commit-Position: refs/heads/master@{#300162}

Powered by Google App Engine
This is Rietveld 408576698