LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll.html - Issue 662603002: [DevTools] Adjust svg elements highlight to the root FrameView origin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll.html

Issue 662603002: [DevTools] Adjust svg elements highlight to the root FrameView origin. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed review comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/elements/highlight-css-shapes-outside-expected.txt ('k') | LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll.html

diff --git a/LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll.html b/LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll.html

index 929c7a5e3ac713b0a005c9b8919635adda4fb7ae..ea59ea40125fb383864c87247c07340d5b8a4c13 100644

--- a/LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll.html

+++ b/LayoutTests/inspector/elements/highlight-css-shapes-outside-scroll.html

@@ -25,21 +25,17 @@

function test()

{

var i = 0;

- function selectNode()

+ function dump()

{

- InspectorTest.selectNodeWithId('circle', evaluate);

- }

- function evaluate(node)

- {

- InspectorTest.dumpInspectorHighlightShape(node, i == 0 ? scroll: InspectorTest.completeTest.bind(InspectorTest));

+ InspectorTest.dumpInspectorHighlightJSON("circle", i == 0 ? scroll : InspectorTest.completeTest.bind(InspectorTest));

}

function scroll()

{

window.scrollTo(0, 100);

++i;

- selectNode();

+ dump();

}

- selectNode();

+ dump();

}

</script>