[DevTools] Adjust svg elements highlight to the root FrameView origin.

Source/core/inspector/InspectorOverlay.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 297 matching lines @@
     RenderObject* renderer = node.renderer();
     if (!renderer)
         return;
 
     highlight->setDataFromConfig(highlightConfig);
 
     // RenderSVGRoot should be highlighted through the isBox() code path, all other SVG elements should just dump their absoluteQuads().
     if (renderer->node() && renderer->node()->isSVGElement() && !renderer->isSVGRoot()) {
         Vector<FloatQuad> quads;
         renderer->absoluteQuads(quads);
-        for (size_t i = 0; i < quads.size(); ++i)
+        FrameView* containingView = renderer->frameView();
+        for (size_t i = 0; i < quads.size(); ++i) {
+            if (containingView)
+                contentsQuadToScreen(containingView, quads[i]);
             highlight->appendQuad(quads[i], highlightConfig.content, highlightConfig.contentOutline);
+        }
         return;
     }
 
     FloatQuad content, padding, border, margin;
     if (!buildNodeQuads(renderer, &content, &padding, &border, &margin))
         return;
     highlight->appendQuad(content, highlightConfig.content, highlightConfig.contentOutline);
     highlight->appendQuad(padding, highlightConfig.padding);
     highlight->appendQuad(border, highlightConfig.border);
     highlight->appendQuad(margin, highlightConfig.margin);
@@ skipping 496 matching lines @@
         RefPtr<TypeBuilder::DOM::ShapeOutsideInfo> shapeTypeBuilder = TypeBuilder::DOM::ShapeOutsideInfo::create()
             .setBounds(buildArrayForQuad(boundsQuad))
             .setShape(ShapePathBuilder::buildPath(*view, *renderer, *shapeOutsideInfo, paths.shape))
             .setMarginShape(ShapePathBuilder::buildPath(*view, *renderer, *shapeOutsideInfo, paths.marginShape));
         model->setShapeOutside(shapeTypeBuilder);
     }
 
     return true;
 }
 
+String InspectorOverlay::getHighlightJSONForNode(Node* node)

[caseq, 2014/10/24 13:31:44]

Can we return JSONObject for better reuse? It's never too late to stringize it.

[dgozman, 2014/10/24 14:45:21]

Done.

+{
+    HighlightConfig config;

[caseq, 2014/10/24 13:31:44]

So we end up with a set of path that are all the same color and hence impossible
to distinguish. Should we make the colors different to improve coverage?

[dgozman, 2014/10/24 14:45:21]

Nice idea! Done.

+    config.showInfo = true;
+    config.showRulers = true;
+    config.showExtensionLines = true;
+    Highlight highlight;
+    appendPathsForShapeOutside(highlight, config, node);
+    buildNodeHighlight(*node, config, &highlight);
+    RefPtr<JSONObject> json(highlight.asJSONObject());
+    return json->toPrettyJSONString();
+}
+
 void InspectorOverlay::freePage()
 {
     if (m_overlayPage) {
         m_overlayPage->willBeDestroyed();
         m_overlayPage.clear();
     }
     m_overlayChromeClient.clear();
     m_timer.stop();
 
     // This will clear internal structures and issue update to the client. Safe to call last.
     hideHighlight();
 }
 
 void InspectorOverlay::startedRecordingProfile()
 {
     if (!m_activeProfilerCount++)
         freePage();
 }
 
 } // namespace blink