Issue 6626028: Modify stateful update clobber logic to write to different file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6626028: Modify stateful update clobber logic to write to different file. (Closed)

Created:
9 years, 9 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, ericli, DaleCurtis

Base URL:
http://git.chromium.org/git/dev-util.git@master

Visibility:
Public.

Description

Modify stateful update clobber logic to write to different file. We no longer want to use clobber-state because /usr/local and /var may have too much data to fit into /tmp. This change has .stateful_update maintain all state rather than the factory file. Change-Id: Ia4fad0395adc5709b84d96a1aef35b88e729fac6 BUG=chromium-os:12209 TEST=Ran in a vm w/ and w/out setting stateful_update file to clean Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8086c3f

Patch Set 1 #

Total comments: 3

Patch Set 2 : nits #

Patch Set 3 : Typo #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -17 lines)			Patch
	M	stateful_update	View	1 2	2 chunks	+19 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

9 years, 9 months ago (2011-03-04 23:31:57 UTC) #2

a couple of nits, LGTM otherwise.

http://codereview.chromium.org/6626028/diff/1/stateful_update
File stateful_update (right):

http://codereview.chromium.org/6626028/diff/1/stateful_update#newcode36
stateful_update:36: DEVSERVER_URL=$(grep CHROMEOS_DEVSERVER
${STATEFUL_DIR}${LSB_RELEASE} | \
no need for trailing \

http://codereview.chromium.org/6626028/diff/1/stateful_update#newcode59
stateful_update:59: if [ ! -d "${STATEFUL_DIR}/var_new" ] || \
no need for trailing \

http://codereview.chromium.org/6626028/diff/1/stateful_update#newcode68
stateful_update:68: touch "${STATEFUL_DIR}/.update_available"
echo -n "" > .update_available

Expand Messages | Collapse Messages