Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(51)

Issue 6626020: Only advance kernel version when the booted partition has a valid key block (Closed)

Created:
9 years, 9 months ago by Randall Spangler
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Only advance kernel version when the booted partition has a valid key block Change-Id: I879c18cc139f8a02bcaa6eb80437eaf836a5e851 BUG=chrome-os-partner:2597 TEST=manual install pvt-signed image flip dev switch on and boot install dev-signed firmware reboot reboot sudo bash stop tcsd tpmc read 0x1008 0x0d bytes 6-10 should be 1 0 1 0, not FF FF FF FF Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c324fbf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M firmware/include/bmpblk_header.h View 1 chunk +1 line, -1 line 0 comments Download
M firmware/include/load_firmware_fw.h View 1 chunk +1 line, -1 line 0 comments Download
M firmware/include/load_kernel_fw.h View 1 chunk +1 line, -1 line 0 comments Download
M firmware/include/tlcl_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M firmware/include/tss_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M firmware/include/vboot_struct.h View 1 chunk +1 line, -1 line 0 comments Download
M firmware/lib/cgptlib/cgptlib.c View 1 chunk +1 line, -1 line 0 comments Download
M firmware/lib/cgptlib/include/cgptlib_internal.h View 1 chunk +1 line, -1 line 0 comments Download
M firmware/lib/cgptlib/include/gpt.h View 1 chunk +1 line, -1 line 0 comments Download
M firmware/lib/rollback_index.c View 1 chunk +1 line, -1 line 0 comments Download
M firmware/lib/tpm_lite/tlcl.c View 1 chunk +1 line, -1 line 0 comments Download
M firmware/lib/vboot_firmware.c View 1 chunk +1 line, -1 line 0 comments Download
M firmware/lib/vboot_kernel.c View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Randall Spangler
9 years, 9 months ago (2011-03-04 20:13:19 UTC) #1
wfrichar
9 years, 9 months ago (2011-03-04 20:19:18 UTC) #2
LGTM (again)

Powered by Google App Engine
This is Rietveld 408576698