Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 662593002: The extension icon on the far right is invisible when about to dragging. (Closed)

Created:
6 years, 2 months ago by Malcolm
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

The extension icon on the far right is invisible when about to dragging. The browser action button on the far right is invisible when user will be dragging the browser actions container. Because the browser action buttons, which don't locate at the extension bar, will be set to be hidden when the dragging finished. So the hidden buttons must be set to be visible before the dragging starts in the next time in order to let user know which extension is coming. BUG=424080 TEST=manually tested. Committed: https://crrev.com/5455db156d000d30e1b3ae26e5d6aaabf47dee93 Cr-Commit-Position: refs/heads/master@{#300049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Malcolm
Hi rsesek, I don't find the proper reviewer for extensions, would you help me to ...
6 years, 2 months ago (2014-10-16 09:35:25 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-16 13:36:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662593002/1
6 years, 2 months ago (2014-10-17 02:07:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 02:50:40 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 02:51:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5455db156d000d30e1b3ae26e5d6aaabf47dee93
Cr-Commit-Position: refs/heads/master@{#300049}

Powered by Google App Engine
This is Rietveld 408576698