Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 662583003: Add gpu support for glVertexAttrb1f, 2fv, and 3fv (Closed)

Created:
6 years, 2 months ago by egdaniel
Modified:
6 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add gpu support for glVertexAttrb1f, 2fv, and 3fv BUG=skia: Committed: https://skia.googlesource.com/skia/+/27c1521ccf0f833affa1182d6d9bc5e31b3af351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
egdaniel
6 years, 2 months ago (2014-10-24 20:20:38 UTC) #2
bsalomon
lgtm
6 years, 2 months ago (2014-10-24 21:06:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662583003/1
6 years, 2 months ago (2014-10-24 21:06:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/275)
6 years, 2 months ago (2014-10-24 21:32:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662583003/1
6 years, 2 months ago (2014-10-24 22:00:07 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 22:01:10 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 27c1521ccf0f833affa1182d6d9bc5e31b3af351

Powered by Google App Engine
This is Rietveld 408576698