Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 662553002: Convert ARRAYSIZE_UNSAFE -> arraysize in net/. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
eroman, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, erikwright (departed), eroman, mmenke, Paweł Hajdan Jr., jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Convert ARRAYSIZE_UNSAFE -> arraysize in net/. R=rsleevi@chromium.org BUG=423134 Committed: https://crrev.com/e4a8b88dc0d38b5ee9a4fb6bde499c404a741f84 Cr-Commit-Position: refs/heads/master@{#299857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -142 lines) Patch
M net/base/address_list_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/escape.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/base/filename_util_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/base/ip_endpoint_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mime_util_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/base/net_log_logger.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/base/net_util_icu_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/net_util_unittest.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M net/cert/multi_threaded_cert_verifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_monster_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cookies/cookie_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/dns/dns_hosts_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/dns/dns_response_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/dns/host_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_util_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/http/http_auth_handler_basic_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_auth_handler_digest_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_auth_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_byte_range_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_cache_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_content_disposition_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_util_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/proxy/proxy_bypass_rules_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/proxy/proxy_config_service_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_list_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_server_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/quic/crypto/crypto_utils_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/iovector_test.cc View 12 chunks +18 lines, -20 lines 0 comments Download
M net/quic/quic_socket_address_coder_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_utils_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/socks_client_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/spdy_session_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/udp/udp_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_throttler_simulation_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_frame_parser_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/websockets/websocket_frame_test.cc View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
viettrungluu
6 years, 2 months ago (2014-10-16 05:15:17 UTC) #1
eroman
lgtm
6 years, 2 months ago (2014-10-16 05:35:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662553002/1
6 years, 2 months ago (2014-10-16 06:00:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 06:17:47 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 06:18:30 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e4a8b88dc0d38b5ee9a4fb6bde499c404a741f84
Cr-Commit-Position: refs/heads/master@{#299857}

Powered by Google App Engine
This is Rietveld 408576698