Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 662533002: [webcrypto] Refactor RSA-SSA signing. (Closed)

Created:
6 years, 2 months ago by eroman
Modified:
6 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[webcrypto] Refactor RSA-SSA signing. This extracts the signing/verification functions, so the subsequent RSA-PSS changelist is easier to follow. BUG=399090 Committed: https://crrev.com/72ce4c6db27260e429a2269cf4ddcb59e9ba2581 Cr-Commit-Position: refs/heads/master@{#300194}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove inconsistent brace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -76 lines) Patch
A content/child/webcrypto/openssl/rsa_sign_openssl.h View 1 chunk +38 lines, -0 lines 0 comments Download
A content/child/webcrypto/openssl/rsa_sign_openssl.cc View 1 1 chunk +105 lines, -0 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_ssa_openssl.cc View 4 chunks +3 lines, -76 lines 0 comments Download
M content/content_child.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
eroman
6 years, 2 months ago (2014-10-15 23:44:41 UTC) #2
Ryan Sleevi
LGTM % nit https://codereview.chromium.org/662533002/diff/1/content/child/webcrypto/openssl/rsa_sign_openssl.cc File content/child/webcrypto/openssl/rsa_sign_openssl.cc (right): https://codereview.chromium.org/662533002/diff/1/content/child/webcrypto/openssl/rsa_sign_openssl.cc#newcode90 content/child/webcrypto/openssl/rsa_sign_openssl.cc:90: if (!EVP_DigestVerifyUpdate(ctx.get(), data.bytes(), data.byte_length())) { style: ...
6 years, 2 months ago (2014-10-17 21:09:56 UTC) #3
eroman
https://codereview.chromium.org/662533002/diff/1/content/child/webcrypto/openssl/rsa_sign_openssl.cc File content/child/webcrypto/openssl/rsa_sign_openssl.cc (right): https://codereview.chromium.org/662533002/diff/1/content/child/webcrypto/openssl/rsa_sign_openssl.cc#newcode90 content/child/webcrypto/openssl/rsa_sign_openssl.cc:90: if (!EVP_DigestVerifyUpdate(ctx.get(), data.bytes(), data.byte_length())) { On 2014/10/17 21:09:55, Ryan ...
6 years, 2 months ago (2014-10-17 22:49:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662533002/20001
6 years, 2 months ago (2014-10-17 23:37:24 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-18 01:12:30 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-18 01:13:23 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72ce4c6db27260e429a2269cf4ddcb59e9ba2581
Cr-Commit-Position: refs/heads/master@{#300194}

Powered by Google App Engine
This is Rietveld 408576698