Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 66253005: shouldBecome* outputs variable name instead of its value on failure (Closed)

Created:
7 years, 1 month ago by grzegorz
Modified:
7 years, 1 month ago
Reviewers:
tony, groby-ooo-7-16
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

shouldBecome* outputs variable name instead of its value on failure shouldBecome{Equal/Different} helper, used to wait for a result of asynchronous operation does not evaluate expected value on failure. As a result, the variable name is printed instead of its value. To consistency with shouldBe() function, shouldBecome* outputs evaluated value on failure. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161912

Patch Set 1 #

Patch Set 2 : update expectations that are supposed to fail with using shouldBecome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M LayoutTests/fast/history/multiple-classes-visited-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/history/nested-visited-test-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/history/self-is-visited-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/history/sibling-visited-test-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/resources/js-test.js View 1 6 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
grzegorz
As shouldBecomeEqual/Different is commonly used in async spellchecking tests I think it's worth fixing it ...
7 years, 1 month ago (2013-11-08 14:00:53 UTC) #1
groby-ooo-7-16
LGTM (Although the variable names tear my heart apart.)
7 years, 1 month ago (2013-11-08 19:19:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/66253005/60001
7 years, 1 month ago (2013-11-13 10:42:26 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 12:25:31 UTC) #4
Message was sent while issue was closed.
Change committed as 161912

Powered by Google App Engine
This is Rietveld 408576698