Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 662513007: Remove trivially-true checks in quic_framer.cc (Closed)

Created:
6 years, 2 months ago by Chris Masone
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wm_events
Project:
chromium
Visibility:
Public.

Description

Remove trivially-true checks in quic_framer.cc There were several places in this file where an error code value was checked to see if it was less than QUIC_NO_ERROR or QUIC_STREAM_NO_ERROR, which are both 0. On some compilers this causes a warning, because such checks are trivially true. BUG=424334 TEST=net_unittests R=rch@chromium.org Committed: https://crrev.com/6e7ef22cb8a5aef89036aeb7d7129fa5890a9480 Cr-Commit-Position: refs/heads/master@{#300368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M net/quic/quic_framer.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Chris Masone
I'm not necessarily convinced this is the right thing to do, as the current code ...
6 years, 2 months ago (2014-10-20 18:55:10 UTC) #1
Ryan Hamilton
lgtm
6 years, 2 months ago (2014-10-20 20:55:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662513007/1
6 years, 2 months ago (2014-10-20 22:22:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 22:47:30 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 22:48:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e7ef22cb8a5aef89036aeb7d7129fa5890a9480
Cr-Commit-Position: refs/heads/master@{#300368}

Powered by Google App Engine
This is Rietveld 408576698