Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 662513005: [turbofan] delete graph and schedule before register allocation. (Closed)

Created:
6 years, 2 months ago by dcarney
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] delete graph and schedule before register allocation. R=mstarzinger@chromium.org, titzer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24894

Patch Set 1 : #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -107 lines) Patch
M src/compiler/common-operator.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/js-graph.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/machine-operator.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/pipeline.h View 1 2 3 2 chunks +3 lines, -11 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 3 11 chunks +206 lines, -93 lines 0 comments Download
M src/compiler/schedule.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/typer.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
dcarney
ptal
6 years, 2 months ago (2014-10-20 13:22:00 UTC) #3
titzer
+mstarzinger
6 years, 2 months ago (2014-10-20 14:01:43 UTC) #5
Michael Starzinger
LGTM, just a coupl'a nits. https://codereview.chromium.org/662513005/diff/100001/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/662513005/diff/100001/src/compiler/pipeline.cc#newcode117 src/compiler/pipeline.cc:117: typer_ = NULL; If ...
6 years, 2 months ago (2014-10-23 12:18:36 UTC) #9
dcarney
6 years, 1 month ago (2014-10-27 09:37:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:140001) manually as 24894 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698