Make the toast more reliable and less dangerous...

Make the toast more reliable and less dangerous

The current toast (re-activation) experiment suffers from the following problems:

1- False negative: the toast can be triggered even if chrome is being used
2- Nested message loop crash: If chrome tries to run while the toast is being shown, it crashes

This change addresses both conditions. Before running the toast we leverage the
process_singleton to detect another instance. If so we abort with "no thanks".

When showing the toast and its nested message loop we take the process_singleton lock which
inhibits dispatch of the wm_copydata message which spawns new tabs in the current process if
we try to span a new tab while in the nested message loop we crash.

BUG=32026
TES=see bug



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77214

[Finnur, 2011-03-07 22:35:10]

OK

http://codereview.chromium.org/6625037/diff/1/chrome/browser/first_run/first_...
File chrome/browser/first_run/first_run.h (right):

http://codereview.chromium.org/6625037/diff/1/chrome/browser/first_run/first_...
chrome/browser/first_run/first_run.h:249: ProcessSingleton* process_singleton);
Please document the new param.

http://codereview.chromium.org/6625037/diff/1/chrome/browser/first_run/first_...
File chrome/browser/first_run/first_run_win.cc (right):

http://codereview.chromium.org/6625037/diff/1/chrome/browser/first_run/first_...
chrome/browser/first_run/first_run_win.cc:867: Upgrade::TryResult
Upgrade::ShowTryChromeDialog(size_t version,
nit: move param |version| down to the line below.

http://codereview.chromium.org/6625037/diff/1/chrome/browser/process_singleton.h
File chrome/browser/process_singleton.h (right):

http://codereview.chromium.org/6625037/diff/1/chrome/browser/process_singleto...
chrome/browser/process_singleton.h:82: // Used in specific cases to let us know
that there an existing instance
nit: s/an/is an/

http://codereview.chromium.org/6625037/diff/1/chrome/browser/process_singleto...
chrome/browser/process_singleton.h:83: // of chrome running with this profile.
In general, you should not use this
nit: s/chrome/Chrome/