Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 662493006: Replace flaky KeyUtils methods with more robust variant. (Closed)

Created:
6 years, 2 months ago by Yaron
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace flaky KeyUtils methods with more robust variant. Relying on instrumentation itself can lead to failures in the event of a popup on the bot (e.g. GooglePlayServices has an update). Instead, send the event to a view directly. BUG=427031 Committed: https://crrev.com/846c034ea7d7868e4198656099e706e90df9fcd4 Cr-Commit-Position: refs/heads/master@{#301397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -47 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/KeyUtils.java View 1 chunk +40 lines, -45 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Yaron
6 years, 2 months ago (2014-10-24 21:37:57 UTC) #2
Yaron
On 2014/10/24 21:37:57, Yaron wrote: downstream callers are gone so this should be good to ...
6 years, 2 months ago (2014-10-25 00:29:21 UTC) #3
Yaron
ping
6 years, 1 month ago (2014-10-27 15:50:30 UTC) #4
David Trainor- moved to gerrit
lgtm
6 years, 1 month ago (2014-10-27 17:10:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662493006/1
6 years, 1 month ago (2014-10-27 17:13:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 18:01:19 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 18:02:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/846c034ea7d7868e4198656099e706e90df9fcd4
Cr-Commit-Position: refs/heads/master@{#301397}

Powered by Google App Engine
This is Rietveld 408576698