[Password Generation] Enable generation for dynamically created forms.

components/autofill/content/renderer/autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_split.h"
@@ skipping 105 matching lines @@
       (*strings)[i].resize(kMaxDataLength);
   }
 }
 
 }  // namespace
 
 AutofillAgent::AutofillAgent(content::RenderView* render_view,
                              PasswordAutofillAgent* password_autofill_agent,
                              PasswordGenerationAgent* password_generation_agent)
     : content::RenderViewObserver(render_view),
       password_autofill_agent_(password_autofill_agent),

[boliu, 2014/10/20 23:24:31]

This seems unsafe as to have two RVObservers have raw pointers to each other. I
don't think destruction order for ObserverList is explicitly defined, although
it's implemented as a vector, might be ok by coincidence.

Much better to have AutofillAgent own PasswordAutofillAgent and
PasswordGenerationAgent, since they all appear to have the same life time
anyway?

I guess it's not an issue of this CL, but should be fixed.

[Garrett Casto, 2014/10/20 23:40:59]

Well, access and deletion of these objects always happens on the UI thread, so I
think that this is safe regardless of destruction order. The setup of having
PasswordAutofillAgent owned by AutofillAgent predates me, so I'm not entirely
sure what the reasoning for this is, but it does make testing easier.

[boliu, 2014/10/20 23:45:09]

The issue is accessing the raw pointer in AutofillAgent destructor. There is
assurance that the object it points to is still there, since ObserverList
destruction order isn't defined.

Not trying to block this CL on this though..

       password_generation_agent_(password_generation_agent),
       autofill_query_id_(0),
       web_view_(render_view->GetWebView()),
       display_warning_if_disabled_(false),
       was_query_node_autofilled_(false),
       has_shown_autofill_popup_for_current_edit_(false),
       did_set_node_text_(false),
       ignore_text_changes_(false),
       is_popup_possibly_visible_(false),
       main_frame_processed_(false),
@@ skipping 586 matching lines @@
 void AutofillAgent::didAssociateFormControls(const WebVector<WebNode>& nodes) {
   for (size_t i = 0; i < nodes.size(); ++i) {
     WebLocalFrame* frame = nodes[i].document().frame();
     // Only monitors dynamic forms created in the top frame. Dynamic forms
     // inserted in iframes are not captured yet. Frame is only processed
     // if it has finished loading, otherwise you can end up with a partially
     // parsed form.
     if (frame && !frame->parent() && !frame->isLoading()) {
       ProcessForms(*frame);
       password_autofill_agent_->OnDynamicFormsSeen(frame);
+      password_generation_agent_->OnDynamicFormsSeen(frame);
       return;
     }
   }
 }
 
 }  // namespace autofill