Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 662473006: Revert "app_shell: Add experimental shellPrivate extension API" (Closed)

Created:
6 years, 2 months ago by James Cook
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Revert "app_shell: Add experimental shellPrivate extension API" This reverts commit e99bfcb9de717ee2bf1d87f1367795bfa90436b9. Going forward app_shell specific APIs will go in //extensions/shell BUG=424651 TEST=compiles Committed: https://crrev.com/0bbe26e33106bf857ef79886e3ddf227fc103034 Cr-Commit-Position: refs/heads/master@{#300150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -103 lines) Patch
M extensions/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D extensions/browser/api/shell_private/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D extensions/browser/api/shell_private/shell_private_api.h View 1 chunk +0 lines, -32 lines 0 comments Download
D extensions/browser/api/shell_private/shell_private_api.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D extensions/browser/api/shell_private/shell_private_api_unittest.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D extensions/common/api/shell_private.idl View 1 chunk +0 lines, -12 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
James Cook
rockot, PTAL Because the existing API does nothing useful I'm going to revert it, then ...
6 years, 2 months ago (2014-10-17 18:08:21 UTC) #3
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-10-17 18:29:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662473006/1
6 years, 2 months ago (2014-10-17 18:36:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 20:04:03 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 20:04:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bbe26e33106bf857ef79886e3ddf227fc103034
Cr-Commit-Position: refs/heads/master@{#300150}

Powered by Google App Engine
This is Rietveld 408576698