Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: components/password_manager/core/browser/login_database.cc

Issue 662443002: [Password Manager] Fix bad SQL update command (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/login_database.cc
diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc
index 050bf8a5e48cb42bf4daae2d2c4b3774a9ea15ca..027e866636be2c22e2f06d3c1b66ade30a97d522 100644
--- a/components/password_manager/core/browser/login_database.cc
+++ b/components/password_manager/core/browser/login_database.cc
@@ -25,7 +25,7 @@ using autofill::PasswordForm;
namespace password_manager {
-static const int kCurrentVersionNumber = 8;
+static const int kCurrentVersionNumber = 7;
static const int kCompatibleVersionNumber = 1;
Pickle SerializeVector(const std::vector<base::string16>& vec) {
@@ -224,13 +224,8 @@ bool LoginDatabase::MigrateOldVersionsAsNeeded() {
}
meta_table_.SetVersionNumber(7);
// Fall through.
- case 7:
- if (!db_.Execute(
- "ALTER TABLE logins DROP COLUMN use_additional_auth")) {
- return false;
- }
- meta_table_.SetVersionNumber(8);
- // Fall through.
+ // TODO(gcasto): Remove use_additional_auth by copying table.
+ // https://www.sqlite.org/lang_altertable.html
case kCurrentVersionNumber:
// Already up to date
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698