Issue 662443002: [Password Manager] Fix bad SQL update command

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 662443002: [Password Manager] Fix bad SQL update command (Closed)

Created:
6 years, 2 months ago by Garrett Casto

Modified:
6 years, 2 months ago

Reviewers:
aurimas (slooooooooow)

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Password Manager] Fix bad SQL update command Bug introduced in crrev.com/0716f6. DROP COLUMN syntax does not exist in SQLite. BUG=423716 Committed: https://crrev.com/e8c29d4eefa54e7e71f4f2284a0903775ef25505 Cr-Commit-Position: refs/heads/master@{#299735}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	components/password_manager/core/browser/login_database.cc	View	1 2	2 chunks	+3 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

aurimas (slooooooooow)

lgtm Sorry for this! I assumed I can just drop things :/

6 years, 2 months ago (2014-10-15 18:14:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662443002/40001

6 years, 2 months ago (2014-10-15 18:17:11 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-15 19:10:20 UTC) #7

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/e8c29d4eefa54e7e71f4f2284a0903775ef25505
Cr-Commit-Position: refs/heads/master@{#299735}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages