Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 662413002: Move some Runtime:: functions and remove runtime.h as include when unnecessary. (Closed)

Created:
6 years, 2 months ago by Yang
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move some Runtime:: functions and remove runtime.h as include when unnecessary. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -162 lines) Patch
M src/api.cc View 4 chunks +59 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 6 chunks +8 lines, -14 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-collections.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-date.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-i18n.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-json.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +0 lines, -57 lines 0 comments Download
M src/runtime/runtime-observe.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-regexp.cc View 2 chunks +0 lines, -42 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-strings.cc View 4 chunks +43 lines, -3 lines 0 comments Download
M src/runtime/runtime-symbol.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/runtime/runtime-uri.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-utils.h View 2 chunks +3 lines, -6 lines 0 comments Download
M src/runtime/string-builder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 2 months ago (2014-10-20 11:36:51 UTC) #1
Benedikt Meurer
LGTM (rubber-stamped)
6 years, 2 months ago (2014-10-20 11:42:12 UTC) #2
Yang
6 years, 2 months ago (2014-10-20 12:08:14 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 24736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698