Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 662403005: Cleanup: Remove IsAlgorithmRsa(). (Closed)

Created:
6 years, 2 months ago by eroman
Modified:
6 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove IsAlgorithmRsa(). This was only being used as a DCHECK() in once place. Removed it because listing IDs in this function goes contrary to modularization of algorithm implementations. Committed: https://crrev.com/45a65be00bb27a352c9ba28b95accf19ebfbaba8 Cr-Commit-Position: refs/heads/master@{#300512}

Patch Set 1 #

Patch Set 2 : rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M content/child/webcrypto/openssl/rsa_key_openssl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/webcrypto/webcrypto_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
eroman
6 years, 2 months ago (2014-10-20 19:38:43 UTC) #2
Ryan Sleevi
lgtm
6 years, 2 months ago (2014-10-20 19:40:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662403005/1
6 years, 2 months ago (2014-10-20 20:15:33 UTC) #5
commit-bot: I haz the power
Failed to apply patch for content/child/webcrypto/webcrypto_util.cc: While running git apply --index -3 -p1; error: patch ...
6 years, 2 months ago (2014-10-20 21:46:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662403005/20001
6 years, 2 months ago (2014-10-20 23:26:30 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/20870)
6 years, 2 months ago (2014-10-21 01:08:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662403005/20001
6 years, 2 months ago (2014-10-21 16:24:03 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-21 17:25:06 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 17:26:10 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/45a65be00bb27a352c9ba28b95accf19ebfbaba8
Cr-Commit-Position: refs/heads/master@{#300512}

Powered by Google App Engine
This is Rietveld 408576698