Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 662403003: Fix mistake in crrev.com/650223005. (Closed)

Created:
6 years, 2 months ago by qyearsley
Modified:
6 years, 2 months ago
Reviewers:
prasadv
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix mistake in crrev.com/650223005. This was the 2nd breaking mistake in that one CL. Note: oth mistakes were not caught by unit tests or by running a bisect try job once before submitting. BUG=425173 Committed: https://crrev.com/91448dd9f5b184282a64d737680de639b725b7c5 Cr-Commit-Position: refs/heads/master@{#300303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/auto_bisect/source_control.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
qyearsley
6 years, 2 months ago (2014-10-20 17:26:56 UTC) #2
qyearsley
On 2014/10/20 17:26:56, qyearsley wrote: Note, the try job that is currently in progress for ...
6 years, 2 months ago (2014-10-20 17:53:08 UTC) #3
prasadv
lgtm
6 years, 2 months ago (2014-10-20 17:57:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662403003/1
6 years, 2 months ago (2014-10-20 18:07:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 18:44:25 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 18:45:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91448dd9f5b184282a64d737680de639b725b7c5
Cr-Commit-Position: refs/heads/master@{#300303}

Powered by Google App Engine
This is Rietveld 408576698