Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Side by Side Diff: Source/devtools/front_end/Runtime.js

Issue 662393007: DevTools: Make compile_frontend.py check code from all applications (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/devtools/scripts/compile_frontend.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 if (descriptor["type"] === "autostart") 312 if (descriptor["type"] === "autostart")
313 coreModuleNames.push(name); 313 coreModuleNames.push(name);
314 } 314 }
315 315
316 Promise.all(moduleJSONPromises).then(instantiateRuntime).done(); 316 Promise.all(moduleJSONPromises).then(instantiateRuntime).done();
317 /** 317 /**
318 * @param {!Array.<!Object>} moduleDescriptors 318 * @param {!Array.<!Object>} moduleDescriptors
319 */ 319 */
320 function instantiateRuntime(moduleDescriptors) 320 function instantiateRuntime(moduleDescriptors)
321 { 321 {
322 for (var i = 0; i < moduleDescriptors.length; ++i) 322 for (var i = 0; !Runtime.isReleaseMode() && i < moduleDescriptors.le ngth; ++i)
323 moduleDescriptors[i]["name"] = configuration[i]["name"]; 323 moduleDescriptors[i]["name"] = configuration[i]["name"];
324 self.runtime = new Runtime(moduleDescriptors, coreModuleNames); 324 self.runtime = new Runtime(moduleDescriptors, coreModuleNames);
325 } 325 }
326 } 326 }
327 } 327 }
328 328
329 /** 329 /**
330 * @param {string} name 330 * @param {string} name
331 * @return {?string} 331 * @return {?string}
332 */ 332 */
(...skipping 705 matching lines...) Expand 10 before | Expand all | Expand 10 after
1038 wasRejected[index] = true; 1038 wasRejected[index] = true;
1039 console.error(e); 1039 console.error(e);
1040 } 1040 }
1041 } 1041 }
1042 1042
1043 // This must be constructed after the query parameters have been parsed. 1043 // This must be constructed after the query parameters have been parsed.
1044 Runtime.experiments = new Runtime.ExperimentsSupport(); 1044 Runtime.experiments = new Runtime.ExperimentsSupport();
1045 1045
1046 /** @type {!Runtime} */ 1046 /** @type {!Runtime} */
1047 var runtime; 1047 var runtime;
OLDNEW
« no previous file with comments | « no previous file | Source/devtools/scripts/compile_frontend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698