Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 662393005: Chromecast: crash upload logic improvements for Android. (Closed)

Created:
6 years, 2 months ago by gunsch
Modified:
6 years, 2 months ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: crash upload logic improvements for Android. * If HTTP 400 is returned from crash server, dump file is rejected. Delete to avoid reattempting later. * Some crash dumps don't have process ID at end. Queue for upload so they either get processed or deleted. R=lcwu@chromium.org,byungchul@chromium.org BUG=None Committed: https://crrev.com/28ee41b69feb19b95e4a33e7ef11b578b321de3a Cr-Commit-Position: refs/heads/master@{#300759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastCrashUploader.java View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
gunsch
6 years, 2 months ago (2014-10-22 03:43:45 UTC) #1
byungchul
lgtm
6 years, 2 months ago (2014-10-22 18:54:10 UTC) #2
lcwu1
lgtm
6 years, 2 months ago (2014-10-22 18:56:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662393005/1
6 years, 2 months ago (2014-10-22 19:00:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/26901) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/10263) linux_chromium_gn_rel ...
6 years, 2 months ago (2014-10-22 19:12:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662393005/1
6 years, 2 months ago (2014-10-22 19:37:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 21:16:51 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 21:18:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28ee41b69feb19b95e4a33e7ef11b578b321de3a
Cr-Commit-Position: refs/heads/master@{#300759}

Powered by Google App Engine
This is Rietveld 408576698