DevTools: scripts: remove manual path concatenation / splitting

DevTools: scripts: remove manual path concatenation / splitting

Use python platform-dependent methods for this.

+ cleanup imports
+ fix execution bit

BUG=425468
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184158

[eustas, 2014-10-21 14:07:23]

eustas@chromium.org changed reviewers:
+ apavlov@chromium.org, yurys@chromium.org

[apavlov, 2014-10-21 14:13:50]

lgtm

https://codereview.chromium.org/662393004/diff/1/Source/devtools/PRESUBMIT.py
File Source/devtools/PRESUBMIT.py (right):

https://codereview.chromium.org/662393004/diff/1/Source/devtools/PRESUBMIT.py...
Source/devtools/PRESUBMIT.py:79: images_src_path =
input_api.os_path.join("devtools", "front_end", "Images", "src")
You can declare devtools_front_end at the top level and reuse it here

https://codereview.chromium.org/662393004/diff/1/Source/devtools/PRESUBMIT.py...
Source/devtools/PRESUBMIT.py:105: images_src_path =
input_api.os_path.join("devtools", "front_end", "Images", "src")
ditto

[apavlov, 2014-10-21 14:23:53]

devtools_file_hashes.py also has '/' hardcoded.

Perhaps, the issue subject should be modified accordingly.

[eustas, 2014-10-21 15:24:35]

PTAL

yurys@ your review is also required

[apavlov, 2014-10-22 06:32:42]

Please fix the subject again. Also, PRESUBMIT.py will not become
platform-agnostic until we remove the input_api.platform.startswith('linux')
check at the top

https://codereview.chromium.org/662393004/diff/20001/Source/devtools/scripts/...
File Source/devtools/scripts/devtools_file_hashes.py (right):

https://codereview.chromium.org/662393004/diff/20001/Source/devtools/scripts/...
Source/devtools/scripts/devtools_file_hashes.py:31: import os.path
from os import path

could let you use just

path.basename(file_path) below

https://codereview.chromium.org/662393004/diff/20001/Source/devtools/scripts/...
File Source/devtools/scripts/optimize_png_images.py (right):

https://codereview.chromium.org/662393004/diff/20001/Source/devtools/scripts/...
Source/devtools/scripts/optimize_png_images.py:91: name =
os.path.splitext(file_name)[0]
This should not be necessary, since you have already done this while building
|svg_file_names|, right?

[yurys, 2014-10-22 07:12:25]

lgtm

[eustas, 2014-10-22 08:08:10]

https://codereview.chromium.org/662393004/diff/20001/Source/devtools/scripts/...
File Source/devtools/scripts/devtools_file_hashes.py (right):

https://codereview.chromium.org/662393004/diff/20001/Source/devtools/scripts/...
Source/devtools/scripts/devtools_file_hashes.py:31: import os.path
On 2014/10/22 06:32:42, apavlov wrote:
> from os import path
> 
> could let you use just
> 
> path.basename(file_path) below

Personally for me this will be less readable.

https://codereview.chromium.org/662393004/diff/20001/Source/devtools/scripts/...
File Source/devtools/scripts/optimize_png_images.py (right):

https://codereview.chromium.org/662393004/diff/20001/Source/devtools/scripts/...
Source/devtools/scripts/optimize_png_images.py:91: name =
os.path.splitext(file_name)[0]
On 2014/10/22 06:32:42, apavlov wrote:
> This should not be necessary, since you have already done this while building
> |svg_file_names|, right?

I'd rather remove first split for consistency.

[apavlov, 2014-10-22 08:21:59]

lgtm

[eustas, 2014-10-22 08:23:58]

The CQ bit was checked by eustas@chromium.org

[commit-bot: I haz the power, 2014-10-22 08:25:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/662393004/40001

[commit-bot: I haz the power, 2014-10-22 09:39:47]

Committed patchset #3 (id:40001) as 184158