Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Issue 662383002: Remove FormData::alwaysStream() (Closed)

Created:
6 years, 2 months ago by hiroshige
Modified:
6 years, 1 month ago
Reviewers:
tkent, Mike West, yhirano
CC:
blink-reviews, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove FormData::alwaysStream() FormData::alwaysStream() doen't seem to be used anywhere in Blink. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184912

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 3 chunks +0 lines, -6 lines 0 comments Download
M Source/platform/network/FormData.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/platform/network/FormData.cpp View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
hiroshige
PTAL when you have time. FormData::alwaysStream() is set (only) by XHR and not used anywhere ...
6 years, 2 months ago (2014-10-22 21:44:50 UTC) #3
yhirano
Thanks, I agree to remove. lgtm
6 years, 2 months ago (2014-10-23 02:03:52 UTC) #4
hiroshige
abarth@, could you take a look as a owner? Thanks
6 years, 1 month ago (2014-11-06 11:14:40 UTC) #6
hiroshige
Sorry, I didn't noticed you are no longer an owner. I'll ask another reviewer.
6 years, 1 month ago (2014-11-06 11:21:47 UTC) #8
hiroshige
tkent@, could you take a look as a platform owner? Thanks
6 years, 1 month ago (2014-11-06 11:24:35 UTC) #10
Mike West
platform/ LGTM.
6 years, 1 month ago (2014-11-06 11:38:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662383002/40001
6 years, 1 month ago (2014-11-06 13:00:03 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 13:39:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 184912

Powered by Google App Engine
This is Rietveld 408576698