CSS Tokenizer: Fix edge cases in number parsing

Source/core/css/parser/CSSTokenizerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/css/parser/CSSTokenizer.h"
 
 #include "core/css/parser/MediaQueryBlockWatcher.h"
 #include "wtf/PassOwnPtr.h"
 #include <gtest/gtest.h>
 
 namespace blink {
 
 typedef struct {
     const char* input;
     const char* output;
 } TestCase;
 
 typedef struct {
     const char* input;
     const unsigned maxLevel;
     const unsigned finalLevel;
 } BlockTestCase;
 
 TEST(CSSTokenizerTest, Basic)
 {
     TestCase testCases[] = {
         { "(max-width: 50px)", "(max-width: 50px)" },
-        { "(max-width: 1e+2px)", "(max-width: 100px)" },
-        { "(max-width: 1e2px)", "(max-width: 100px)" },
-        { "(max-width: 1000e-1px)", "(max-width: 100px)" },
+        { "(max-width: 1e+2px)", "(max-width: 100.000000px)" },
+        { "(max-width: 1e2px)", "(max-width: 100.000000px)" },
+        { "(max-width: 1000e-1px)", "(max-width: 100.000000px)" },

[Yoav Weiss, 2014/10/20 07:06:46]

These tests would fail on some system locales, where '.' is replaced by ','.
You should add "setlocale(LC_NUMERIC, "en_US.UTF-8");" to
CSSParserToken::textForUnitTests (and include <locale.h>) to make this go away.

[Timothy Loh, 2014/10/20 07:18:24]

Good catch. There's probably a more appropriate float->string helper in WTF
somewhere, I'll have a look.

         { "(max-width: 50\\70\\78)", "(max-width: 50px)" },
         { "(max-width: /* comment */50px)", "(max-width: 50px)" },
         { "(max-width: /** *commen*t */60px)", "(max-width: 60px)" },
         { "(max-width: /** *commen*t **/70px)", "(max-width: 70px)" },
         { "(max-width: /** *commen*t **//**/80px)", "(max-width: 80px)" },
         { "(max-width: /*/ **/90px)", "(max-width: 90px)" },
         { "(max-width: /*/ **/*100px)", "(max-width: '*'100px)" },
         { "(max-width: 110px/*)", "(max-width: 110px" },
         { "(max-width: 120px)/*", "(max-width: 120px)" },
         { "(max-width: 130px)/**", "(max-width: 130px)" },
         { "(max-width: /***/140px)/**/", "(max-width: 140px)" },
         { "(max-width: '40px')", "(max-width: 40px)" },
         { "(max-width: '40px", "(max-width: 40px" },
         { "(max-width: '40px\n", "(max-width:  " },
         { "(max-width: '40px\\", "(max-width: 40px" },
         { "(max-width: '40px\\\n", "(max-width: 40px" },
         { "(max-width: '40px\\\n')", "(max-width: 40px)" },
         { "(max-width: '40\\70\\78')", "(max-width: 40px)" },
         { "(max-width: '40\\\npx')", "(max-width: 40px)" },
         { "(max-aspect-ratio: 5)", "(max-aspect-ratio: 5)" },
         { "(max-aspect-ratio: +5)", "(max-aspect-ratio: 5)" },
         { "(max-aspect-ratio: -5)", "(max-aspect-ratio: -5)" },
         { "(max-aspect-ratio: -+5)", "(max-aspect-ratio: '-'5)" },
         { "(max-aspect-ratio: +-5)", "(max-aspect-ratio: '+'-5)" },
         { "(max-aspect-ratio: +bla5)", "(max-aspect-ratio: '+'bla5)" },
         { "(max-aspect-ratio: +5bla)", "(max-aspect-ratio: 5other)" },
         { "(max-aspect-ratio: -bla)", "(max-aspect-ratio: -bla)" },
         { "(max-aspect-ratio: --bla)", "(max-aspect-ratio: '-'-bla)" },
+        { "5e0", "5.000000" },
+        { "5.0", "5.000000" },
+        { "5.", "5'.'" },
+        { "5.0e-1", "0.500000" },
+        { "5.e-1", "5'.'e-1" },
         { 0, 0 } // Do not remove the terminator line.
     };
 
     for (int i = 0; testCases[i].input; ++i) {
         Vector<CSSParserToken> tokens;
         CSSTokenizer::tokenize(testCases[i].input, tokens);
         StringBuilder output;
         for (size_t j = 0; j < tokens.size(); ++j)
             output.append(tokens[j].textForUnitTests());
         ASSERT_STREQ(testCases[i].output, output.toString().ascii().data());
@@ skipping 94 matching lines @@
             testToken(c, EOFToken);
         else if (c > SCHAR_MAX)
             testToken(c, IdentToken);
         else
             testToken(c, DelimiterToken);
     }
     testToken(USHRT_MAX, IdentToken);
 }
 
 } // namespace