Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Issue 662313003: Add isExpanded() API to WebAXObject.h to get aria-expanded attribute. (Closed)

Created:
6 years, 2 months ago by je_julie(Not used)
Modified:
6 years, 2 months ago
Reviewers:
*dmazzoni, Mike West
CC:
blink-reviews, dglazkov+blink, dmazzoni, aboxhall, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add isExpanded() API to WebAXObject.h to get aria-expanded attribute. This patch also moves isExpanded() in AXObject to AXNodeObject like other APIs to get attribute. BUG=98982 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M Source/core/accessibility/AXNodeObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/accessibility/AXNodeObject.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/accessibility/AXObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/accessibility/AXObject.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/web/WebAXObject.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M public/web/WebAXObject.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
je_julie(Not used)
Hi Dominic and Mike, The related CL in chromium is https://codereview.chromium.org/665843002/ I'll update TC results ...
6 years, 2 months ago (2014-10-20 05:30:21 UTC) #2
Mike West
public/ LGTM, but please don't proceed with this unless Dominic agrees that it's the right ...
6 years, 2 months ago (2014-10-20 07:54:55 UTC) #4
dmazzoni
lgtm
6 years, 2 months ago (2014-10-20 16:36:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662313003/1
6 years, 2 months ago (2014-10-21 08:07:54 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 09:15:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184058

Powered by Google App Engine
This is Rietveld 408576698