Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1793)

Issue 662273003: Move ImportantFile.TempFileFailures to histograms.xml. (Closed)

Created:
6 years, 2 months ago by Thiemo Nagel
Modified:
6 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ImportantFile.TempFileFailures to histograms.xml. At that occasion, make it owned by rvargas@. BUG=none Committed: https://crrev.com/5dc312a3e602859f169ca1c7c26d12a8fd9107e2 Cr-Commit-Position: refs/heads/master@{#300320}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Save "flushing" for a separate CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Thiemo Nagel
Hi Alexei, could you please take a look? Thank you! Thiemo
6 years, 2 months ago (2014-10-20 07:17:14 UTC) #5
Alexei Svitkine (slow)
LGTM % comment (i.e. remove the new enum value from this CL and it's good ...
6 years, 2 months ago (2014-10-20 15:25:35 UTC) #6
Thiemo Nagel
Thank you, Alexei! Ricardo, are you ok with the CL? https://codereview.chromium.org/662273003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/662273003/diff/1/tools/metrics/histograms/histograms.xml#newcode53065 ...
6 years, 2 months ago (2014-10-20 16:22:39 UTC) #7
rvargas (doing something else)
lgtm
6 years, 2 months ago (2014-10-20 18:24:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662273003/20001
6 years, 2 months ago (2014-10-20 18:37:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 20:18:47 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 20:19:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5dc312a3e602859f169ca1c7c26d12a8fd9107e2
Cr-Commit-Position: refs/heads/master@{#300320}

Powered by Google App Engine
This is Rietveld 408576698