Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 662273002: gfx:: De-templatize Size and SizeF. (Closed)

Created:
6 years, 2 months ago by danakj
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), oshima, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gfx:: De-templatize Size and SizeF. This shrinks the android ChromeShell binary by 1076 bytes, and makes the code easier for developers to read. Performance-wise this change seems neutral (as opposed to the perf wins from similar changes for Rect and Point classes). Performance numbers are at http://crbug.com/407444#c19 R=sky BUG=407444 Committed: https://crrev.com/adb045fd004834946c39bc11c24399ac4ebbac7c Cr-Commit-Position: refs/heads/master@{#300285}

Patch Set 1 #

Patch Set 2 : inlines-size: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -106 lines) Patch
M ui/gfx/geometry/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/geometry/size.h View 4 chunks +32 lines, -10 lines 0 comments Download
M ui/gfx/geometry/size.cc View 2 chunks +23 lines, -15 lines 0 comments Download
D ui/gfx/geometry/size_base.h View 1 chunk +0 lines, -69 lines 0 comments Download
M ui/gfx/geometry/size_f.h View 3 chunks +29 lines, -8 lines 0 comments Download
M ui/gfx/geometry/size_f.cc View 1 chunk +17 lines, -1 line 0 comments Download
M ui/gfx/geometry/size_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
danakj
6 years, 2 months ago (2014-10-18 21:25:21 UTC) #1
sky
LGTM
6 years, 2 months ago (2014-10-20 16:41:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/662273002/20001
6 years, 2 months ago (2014-10-20 16:43:15 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 17:12:51 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 17:14:05 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/adb045fd004834946c39bc11c24399ac4ebbac7c
Cr-Commit-Position: refs/heads/master@{#300285}

Powered by Google App Engine
This is Rietveld 408576698