Issue 662233003: Restoring tests incorrectly removed in cr/77591875

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 662233003: Restoring tests incorrectly removed in cr/77591875 (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)

Modified:
6 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett, rjshade

Base URL:
https://chromium.googlesource.com/chromium/src.git@Replace_calls_to_set_count_77762867

Project:
chromium

Visibility:
Public.

More Reviews

Description

Restoring tests incorrectly removed in cr/77591875 Merge internal change: 77791119 Commented out headers_stream->HasBufferedData() call to fix flaky HandshakeUnblocksFlowControlBlockedHeadersStream unit test. BUG=423586 R=rch@chromium.org

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -2 lines)			Patch
	M	net/quic/quic_session_test.cc	View		4 chunks	+167 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

https://codereview.chromium.org/662233003/diff/1/net/quic/quic_session_test.cc File net/quic/quic_session_test.cc (right): https://codereview.chromium.org/662233003/diff/1/net/quic/quic_session_test.cc#newcode748 net/quic/quic_session_test.cc:748: // EXPECT_TRUE(headers_stream->HasBufferedData()); rjshade@: HandshakeUnblocksFlowControlBlockedHeadersStream is flaky and fails at ...

6 years, 2 months ago (2014-10-20 19:05:06 UTC) #2

Ryan Hamilton

6 years, 2 months ago (2014-10-20 21:22:49 UTC) #3

lgtm, but very curious to hear what rjshade thinks about the flakiness.

Expand Messages | Collapse Messages