NSS: {EC,RSA}PrivateKey shouldn't call crypto::GetPublicNSSKeySlot or GetPrivateNSSKeySlot.

remoting/remoting.gyp

Index: remoting/remoting.gyp
diff --git a/remoting/remoting.gyp b/remoting/remoting.gyp
index fb3eb9344a216d726ebc6c3606fa5f8bbc690c6a..c87f22774f3848255046db9247bd6bcfe4fa2ccb 100644
--- a/remoting/remoting.gyp
+++ b/remoting/remoting.gyp
@@ -2481,6 +2481,7 @@
       'dependencies': [
         '../base/base.gyp:base',
         '../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
+        '../crypto/crypto.gyp:crypto',
         '../ui/gfx/gfx.gyp:gfx',
         '../ui/ui.gyp:ui',
         '../net/net.gyp:net',
@@ -2783,6 +2784,7 @@
         '../base/base.gyp:base',
         '../base/base.gyp:base_i18n',
         '../base/base.gyp:test_support_base',
+        '../crypto/crypto.gyp:crypto',

[wtc, 2013/11/11 20:56:25]

Question: can we satisfy the dependency on '../crypto/crypto.gyp:crypto' via
'remoting_base' (line 2795)?

[mattm, 2013/11/12 02:42:44]

It seemed like crypto dep has to be added directly for the include path to get
set.  However, I switched to not using ScopedPK11Slot in the public interface,
so these changes aren't necessary anymore (there were more that I had missed
too).

         '../ipc/ipc.gyp:ipc',
         '../net/net.gyp:net_test_support',
         '../ppapi/ppapi.gyp:ppapi_cpp',