Drover's back, baby!

go/src/infra/libs/git/blob.go

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+package git

[M-A Ruel, 2014/10/21 00:55:53]

you need to keep an empty line, otherwise it is considered package
documentation. You can confirm with godoc -http=:6060

[iannucci, 2016/05/23 21:53:42]

oh, yikes, ok

+
+// Blob is a git Object which represents file data
+type Blob struct {
+        id   ObjectID
+        data string

[M-A Ruel, 2014/10/21 00:55:53]

So you really use string here as []byte. I think I'd prefer []byte. String has
implication that it is somehow human readable.

[iannucci, 2016/05/23 21:53:42]

Well... most blobs /are/ human readable (usually text files). The other
advantage is that string is immutable but []byte is not, which means one less
copy.

+}
+
+func (b *Blob) ID() ObjectID      { return b.id }
+func (b *Blob) Type() ObjectType  { return BlobType }
+func (b *Blob) Complete() bool    { return true }
+func (b *Blob) RawString() string { return b.data }
+
+// BlobFromRaw creates a new *Blob, calculating the ID() from |data|
+func BlobFromRaw(data []byte) *Blob {
+        return BlobFromRawWithID(MakeObjectIDForData(BlobType, data), data)
+}
+
+// BlobFromRawWithID creates a new *Blob, trusting |id|. There is no verification

[M-A Ruel, 2014/10/21 00:55:53]

Generally I personally ensure these docstrings are 80 cols.

[iannucci, 2016/05/23 21:53:42]

Done.

+// that |data| and |id| match.
+func BlobFromRawWithID(id ObjectID, data []byte) *Blob {
+        return &Blob{id, string(data)}
+}