go/src/infra/libs/git/diff.go - Issue 662113003: Drover's back, baby!

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: go/src/infra/libs/git/diff.go

Issue 662113003: Drover's back, baby! (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git/+/master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 package git

	2

	3 import "fmt"

	4 import "strings"

	5

	6 func (r *Repo) GetTextDiff(left, right string) []string {
	M-A Ruel 2014/10/18 00:47:05 Why not implement in repo.go or where ever you def Why not implement in repo.go or where ever you define Repo? M-A Ruel 2014/10/18 00:47:05 Why []string instead of string? Why []string instead of string? iannucci 2014/10/20 21:11:57 Fair enough. Show quoted text On 2014/10/18 00:47:05, M-A Ruel wrote: > Why []string instead of string? Fair enough. iannucci 2014/10/20 21:11:57 Done. Show quoted text On 2014/10/18 00:47:05, M-A Ruel wrote: > Why not implement in repo.go or where ever you define Repo? Done.
	7 rslt, ok := r.Run("diff", left, right)

	8 if !ok {

	9 panic(fmt.Errorf("cannot diff(%s, %s): %s", left, right, rslt))
	M-A Ruel 2014/10/18 00:47:05 No, change the signature to return ([]string, erro No, change the signature to return ([]string, error) then return nil, fmt.Errorf(... iannucci 2014/10/20 21:11:57 Done. Show quoted text On 2014/10/18 00:47:05, M-A Ruel wrote: > No, change the signature to return ([]string, error) > then > return nil, fmt.Errorf(... Done.
	10 }

	11 return strings.Split(rslt, "\n")
	M-A Ruel 2014/10/18 00:47:05 return strings.Split(rslt, "\n"), nil return strings.Split(rslt, "\n"), nil iannucci 2014/10/20 21:11:57 Done. Show quoted text On 2014/10/18 00:47:05, M-A Ruel wrote: > return strings.Split(rslt, "\n"), nil Done.
	12 }

OLD	NEW