Reset child_process_launcher after notifying observers

content/browser/renderer_host/render_process_host_impl.cc

Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index a5e9dde5974c8f13d19ec19c1e750d62fc05f912..4bddba20880f2d83f3aff5a2861c247bbd75a323 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -1903,7 +1903,6 @@ void RenderProcessHostImpl::ProcessDied(bool already_dead) {
   RendererClosedDetails details(GetHandle(), status, exit_code);
   mojo_application_host_->WillDestroySoon();
 
-  child_process_launcher_.reset();

[no sievers, 2014/10/17 19:08:29]

This should already provide the old handle because it is queried above.

Of course the handle is not valid anymore, but with your proposed change you are
changing both NOTIFICATION_RENDERER_PROCESS_CLOSED and RenderProcessExited to
NOTIFICATION_RENDERER_PROCESS_ABOUT_TO_CLOSE/RenderProcessAboutToExit which
might have subtle implications.

   channel_.reset();
 
   within_process_died_observer_ = true;
@@ -1916,6 +1915,7 @@ void RenderProcessHostImpl::ProcessDied(bool already_dead) {
                     RenderProcessExited(this, status, exit_code));
   within_process_died_observer_ = false;
 
+  child_process_launcher_.reset();
   gpu_message_filter_ = NULL;
   message_port_message_filter_ = NULL;
   RemoveUserData(kSessionStorageHolderKey);