Fix VPN dropdown menu in Settings

Fix VPN dropdown menu in Settings

This addresses two issues:
* Disconnect will correctly disconnect from the first connected or
  connecting network
* Join other... is restored to the VPN dropdown

BUG=424723
Committed: https://crrev.com/7107b02878b9dd215555cbd52db0afefea2d2c9a
Cr-Commit-Position: refs/heads/master@{#300728}

[stevenjb, 2014-10-22 16:24:19]

stevenjb@chromium.org changed reviewers:
+ pneubeck@chromium.org, tbarzic@chromium.org

[tbarzic, 2014-10-22 17:06:57]

lgtm

https://codereview.chromium.org/662063005/diff/20001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/network_list.js (right):

https://codereview.chromium.org/662063005/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/network_list.js:546: // since there
should only ever be one connected or connecting VPN.
nit: Maybe it would be better to say that it should be OK to show 'Disconnect'
rather than we want to show it because there is at most one connected VPN.

https://codereview.chromium.org/662063005/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/network_list.js:548: (data.Type ==
'VPN') &&
nit: I'd drop () here

[stevenjb, 2014-10-22 17:31:33]

https://codereview.chromium.org/662063005/diff/20001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/network_list.js (right):

https://codereview.chromium.org/662063005/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/network_list.js:546: // since there
should only ever be one connected or connecting VPN.
On 2014/10/22 17:06:57, tbarzic wrote:
> nit: Maybe it would be better to say that it should be OK to show 'Disconnect'
> rather than we want to show it because there is at most one connected VPN.

Actually, I guess that's true for any network type, we just decided to add it to
VPN for convenience. I'll simplify the comment.

https://codereview.chromium.org/662063005/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/network_list.js:548: (data.Type ==
'VPN') &&
On 2014/10/22 17:06:57, tbarzic wrote:
> nit: I'd drop () here

Done.

[stevenjb, 2014-10-22 17:31:41]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-10-22 17:32:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/662063005/40001

[commit-bot: I haz the power, 2014-10-22 19:25:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-22 19:27:00]

Patchset 3 (id:??) landed as
https://crrev.com/7107b02878b9dd215555cbd52db0afefea2d2c9a
Cr-Commit-Position: refs/heads/master@{#300728}