Chromium Code Reviews Chromium Code Reviews
Issue 662013004:
fix duplicate script issue (Closed)
Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart| Index: pkg/polymer/lib/src/build/messages.dart |
| diff --git a/pkg/polymer/lib/src/build/messages.dart b/pkg/polymer/lib/src/build/messages.dart |
| index 24b88b649acefdce41c237b6af67f0dd5745dac7..5e2d3b6fef79df82f3e514652aa89f4a9bf3a543 100644 |
| --- a/pkg/polymer/lib/src/build/messages.dart |
| +++ b/pkg/polymer/lib/src/build/messages.dart |
| @@ -580,3 +580,27 @@ half. Developers of packages that wrap JavaScript custom elements (like |
| application developers don't have to worry about it anymore. |
| ''' |
| ); |
| + |
| +const SCRIPT_INCLUDED_MORE_THAN_ONCE = const MessageTemplate( |
| + const MessageId('polymer', 44), |
| + 'The `%-url-%` script was included more than once.', |
| + 'A dart script file was included more than once.', |
|
Siggi Cherem (dart-lang)
2014/10/21 17:06:03
to be consistent with the titles we use above - Ka
jakemac
2014/10/21 18:14:01
Done.
|
| + ''' |
| +Duplicate dart scripts often happen if you have multiple html imports that |
| +include the same script. The simplest workaround for this is to move your dart |
| +script to its own html file, and import that instead of the script (html imports |
| +are automatically deduped). |
| + |
| +For example: |
| + |
| + <script type="application/dart" src="foo.dart"></script> |
| + |
| +Should turn into: |
| + |
| + <link rel="import" href="foo.html"> |
| + |
| +And `foo.html` should look like: |
| + |
| + <!DOCTYPE html> |
|
Siggi Cherem (dart-lang)
2014/10/21 17:06:03
we can omit the doctype actually
jakemac
2014/10/21 18:14:01
Done.
|
| + <script type="application/dart" src="foo.dart"></script> |
| +'''); |
